DM-40395: Allow datastore record inserts to use ensure or replace #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 87.71% 87.70% -0.01%
==========================================
Files 274 274
Lines 36117 36195 +78
Branches 7553 7575 +22
==========================================
+ Hits 31680 31746 +66
- Misses 3264 3272 +8
- Partials 1173 1177 +4
☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-40395
branch
2 times, most recently
from
1e18bb7
to
469238c
Compare
andy-slac
approved these changes
Aug 18, 2023
timj
force-pushed
the
tickets/DM-40395
branch
3 times, most recently
from
120c7a2
to
c26b00b
Compare
This should have been done when we removed the support for ingesting unresolved refs.
…uations Until we have a coherent way of handling record clashes, for ingest assume that if UUIDv5 IDs are being used and the file is not going to be transferred into the datastore, then replacing existing records is allowable.
This is a questionable change and needs some further thought, but it is more consistent with what is actually happening and the chances of a disassembled composite and an assembled composite clashing are low.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't solve the real problem of the files being overwritten without us knowing whether the datastore records are allowed to be modified but it does give the option.
Checklist
doc/changes