DM-40462: Move DbAuth class from daf_butler to utils #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DbAuth` is generally useful to other packages that do not have dependency on `daf_butler`. Simply moved the whole module and unit tests from here to `utils`.
andy-slac
force-pushed
the
tickets/DM-40462
branch
from
9fd63a7
to
3508ad6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
==========================================
- Coverage 87.70% 87.64% -0.07%
==========================================
Files 274 272 -2
Lines 36219 36005 -214
Branches 7578 7529 -49
==========================================
- Hits 31767 31557 -210
+ Misses 3274 3272 -2
+ Partials 1178 1176 -2
☔ View full report in Codecov by Sentry. |
andy-slac
force-pushed
the
tickets/DM-40462
branch
from
3508ad6
to
5daa21f
Compare
TallJimbo
approved these changes
Aug 22, 2023
andy-slac
force-pushed
the
tickets/DM-40462
branch
from
5daa21f
to
05e3c86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DbAuthis generally useful to other packages that do not have dependency ondaf_butler. Simply moved the whole module and unit tests from here toutils.Checklist
doc/changes