DM-41226: Remove datastore records from serialized DatasetRef #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
- Coverage 87.60% 87.59% -0.01%
==========================================
Files 272 272
Lines 36600 36584 -16
Branches 7641 7637 -4
==========================================
- Hits 32062 32046 -16
Misses 3351 3351
Partials 1187 1187
☔ View full report in Codecov by Sentry. |
This removes the piece of code for (de-)serializing datastore records in DatasetRef that was added on DM-40053. We worry that serialized QuantumGraph could grow in size, though presently we do not fill datastore records when we make refs for quantum graph. In the future the whole thing will be replaced by a more efficient data structures, so this serialization will likely disappear entirely.
andy-slac
force-pushed
the
tickets/DM-41226
branch
from
674a7e3
to
584df7a
Compare
TallJimbo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the piece of code for (de-)serializing datastore records in DatasetRef that was added on DM-40053. We worry that serialized QuantumGraph could grow in size, though presently we do not fill datastore records when we make refs for quantum graph. In the future the whole thing will be replaced by a more efficient data structures, so this serialization will likely disappear entirely.
Checklist
doc/changes