Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-13371: flake8 compliance #9

Merged
merged 3 commits into from Jan 26, 2018
Merged

DM-13371: flake8 compliance #9

merged 3 commits into from Jan 26, 2018

Conversation

timj
Copy link
Member

@timj timj commented Jan 26, 2018

This fixes most of the problems. There are some remaining problems with sqlRegistry.py and units.py that I need to talk to @pschella about.

@timj timj requested a review from pschella January 26, 2018 00:52
@timj
Copy link
Member Author

timj commented Jan 26, 2018 

============================================================================= FAILURES =============================================================================
____________________________________________________ FLAKE8-check(ignoring E133 E226 E228 E251 N802 N803 N806) _____________________________________________________
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:37:9: N805 first argument of a method should be named 'self'
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:227:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:238:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:276:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:286:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:341:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:354:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:359:13: F841 local variable 'abstractFilterName' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:426:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:442:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:522:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:539:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:544:13: F841 local variable 'physicalFilterName' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:604:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:620:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:628:13: F841 local variable 'physical_sensor_number' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:700:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:717:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:747:22: F821 undefined name '_camera'
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:747:31: F821 undefined name '_visitBegin'
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:747:44: F821 undefined name '_visitEnd'
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:780:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:794:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:851:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:863:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:911:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:924:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:995:36: F841 local variable 'transaction' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/core/units.py:1012:36: F841 local variable 'transaction' is assigned to but never used

____________________________________________________ FLAKE8-check(ignoring E133 E226 E228 E251 N802 N803 N806) _____________________________________________________
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/registries/sqlRegistry.py:161:9: F841 local variable 'datasetId' is assigned to but never used
/Users/timj/work/lsstsw3/build/daf_butler/python/lsst/daf/butler/registries/sqlRegistry.py:329:17: F841 local variable 'registryId' is assigned to but never used

@timj timj merged commit 012c14e into master Jan 26, 2018
@ktlim ktlim deleted the tickets/DM-13371 branch August 25, 2018 06:49
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Aug 6, 2019
@DinoBektesevic
Review fixes lsst#9
743401f 
Updated formatters to use fileDescriptors as attributes.

Updated S3Datastores to match the new formatters. Fixed
mistakes in S3Datastore ingest functionality. Removed
hardcoded path manipulations.

Fixes to S3Datastore put functionality, missing
constraints checks added in.  Prettification and
correction of comments in get functionality.
Additional chekcs added. Fixes to getUri
functionality, somehow it seems it never got updated
when ButlerURI class was written.

Implemented review requests in ButlerURI.
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Aug 6, 2019
@DinoBektesevic
Review fixes lsst#9
75156aa 
Updated formatters to use fileDescriptors as attributes.

Updated S3Datastores to match the new formatters. Fixed
mistakes in S3Datastore ingest functionality. Removed
hardcoded path manipulations.

Fixes to S3Datastore put functionality, missing
constraints checks added in.  Prettification and
correction of comments in get functionality.
Additional chekcs added. Fixes to getUri
functionality, somehow it seems it never got updated
when ButlerURI class was written.

Implemented review requests in ButlerURI.
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Aug 6, 2019
@DinoBektesevic
Review fixes lsst#9
7aa6d30 
Updated formatters to use fileDescriptors as attributes.

Updated S3Datastores to match the new formatters. Fixed
mistakes in S3Datastore ingest functionality. Removed
hardcoded path manipulations.

Fixes to S3Datastore put functionality, missing
constraints checks added in.  Prettification and
correction of comments in get functionality.
Additional chekcs added. Fixes to getUri
functionality, somehow it seems it never got updated
when ButlerURI class was written.

Implemented review requests in ButlerURI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschella pschella Awaiting requested review from pschella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timj