Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-15760: Change first/last validity from exposure ID to datetime #90

Merged
merged 1 commit into from
Sep 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions config/dataUnits.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ dataUnits:
required:
- Camera
doc: >
An inclusive range of Exposures that may be open in either
An inclusive range of Exposure dates that may be open in either
direction, typically used to identify master calibration products.
There is no SQL table associated with ExposureRanges; there is no
additional information associated with an ExposureRange besides the
Expand Down Expand Up @@ -171,7 +171,7 @@ dataUnits:
rhs: [ExposureRange]
sql:
(lhs.camera = rhs.camera) AND
(lhs.exposure BETWEEN rhs.valid_first AND rhs.valid_last)
(lhs.datetime_begin BETWEEN rhs.valid_first AND rhs.valid_last)
MultiCameraExposureJoin:
doc: >
A join table that relates Exposures from different Cameras, with
Expand Down Expand Up @@ -290,4 +290,3 @@ dataUnits:
- VisitSensorPatchJoin
- VisitSensorTractJoin
- VisitPatchJoin

12 changes: 6 additions & 6 deletions config/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,16 @@ schema:
type: int
-
name: valid_first
type: int
type: datetime
doc: >
First exposure identifier included in the range (inclusive). may
be zero to indicate an open interval.
TAI timestamp of first exposure included in the range (inclusive).
May be far in the past to indicate an open interval.
-
name: valid_last
type: int
type: datetime
doc: >
Last exposure identifier included in the range (inclusive). may
be max(int) to indicate an open interval.
TAI timestamp of last exposure included in the range (inclusive).
May be far in the future to indicate an open interval.
-
name: skypix
type: int
Expand Down