DM-42214: Remove unused dbAuth test files #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 295 295
Lines 38327 38331 +4
Branches 8097 8098 +1
=======================================
+ Hits 33588 33592 +4
Misses 3535 3535
Partials 1204 1204 ☔ View full report in Codecov by Sentry. |
dhirving
approved these changes
Dec 15, 2023
timj
force-pushed
the
tickets/DM-42214
branch
from
d233b89
to
51e4345
Compare
The bad yaml file did not really need to be stored in the repo and it's almost as easy to create it when the test runs. This allows us to stop fighting YAML linters complaining about the bad file.
It was doing nothing after we moved all the files out of core/ I am unable to get pydocstyle to ignore the parser code which is not compliant so instead am attempting to filter it out using find and grep.
ruff does not find them. These were only discovered once pydocstyle was fixed to scan the full code tree.
timj
force-pushed
the
tickets/DM-42214
branch
from
51e4345
to
8a57ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes