DM-38687: Remove deprecated DimensionPacker factory methods. #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-38687
branch
from
cd2546f
to
b8c61c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
==========================================
+ Coverage 88.00% 88.08% +0.07%
==========================================
Files 308 307 -1
Lines 39452 39365 -87
Branches 8309 8295 -14
==========================================
- Hits 34720 34673 -47
+ Misses 3524 3484 -40
Partials 1208 1208 ☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-38687
branch
from
b8c61c8
to
9e5618a
Compare
|
Looks good to me! |
TallJimbo
force-pushed
the
tickets/DM-38687
branch
from
9e5618a
to
c1a2340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes