DM-42138: Add test for get_dataset collection caching #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 301 301
Lines 39204 39211 +7
Branches 8277 8277
=======================================
+ Hits 34477 34484 +7
Misses 3525 3525
Partials 1202 1202 ☔ View full report in Codecov by Sentry. |
timj
approved these changes
Jan 2, 2024
Add a test to ensure that get_dataset will not throw a MissingCollectionError for datasets added since the last collection refresh.
dhirving
force-pushed
the
tickets/DM-42138
branch
from
76217ec
to
b6dd0c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to ensure that get_dataset will not throw a MissingCollectionError for datasets added since the last collection refresh.
Checklist
doc/changes