Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40150: Remove some APIs scheduled for removal after v26 #937

Merged
merged 9 commits into from Jan 5, 2024
Merged

DM-40150: Remove some APIs scheduled for removal after v26 #937

merged 9 commits into from Jan 5, 2024

Conversation

timj
Copy link
Member

@timj timj commented Jan 4, 2024 •
edited

  • Butler.datastore
  • Butler.getDirect*
  • Butler.datasetExists
  • run and idGenerationMode removed from Butler.ingest

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e04138) 88.31% compared to head (e0e8ef3) 88.36%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   88.31%   88.36%   +0.04%     
==========================================
  Files         306      306              
  Lines       39226    39167      -59     
  Branches     8256     8233      -23     
==========================================
- Hits        34641    34608      -33     
+ Misses       3393     3371      -22     
+ Partials     1192     1188       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TallJimbo
TallJimbo approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"long bean" typo in the idGenerationMode commit's message

@timj
Remove idGenerationMode parameter from Butler.ingest
c353972 
Now that DatasetRef is required to have a UUID, this parameter
has long been ignored.
@timj
Modernize pydantic model usage -- model_dump_json()
912969f
@timj
DM-40081: Remove run parameter from Butler.ingest
091caee 
This was deprecated but somehow didn't say when it was going
to be removed.
@timj
Remove the butler import --reuse-ids option
17bf57c 
This has not been useful since integer IDs were allowed.
@timj
Remove the unused reconstitutedDimensions parameter from from_simple
10960bb
@timj timj merged commit d0dcdfc into main Jan 5, 2024
18 checks passed
@timj timj deleted the tickets/DM-40150 branch January 5, 2024 21:16
@timj timj mentioned this pull request Jan 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo