DM-42416: Modify without_datastore test to use file config #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In w.2023.50 the test passed because the config was sent as a Config object, but would fail if a path to a Config was used instead. Rewrite the test to use a file (which works now due to a later reorganization).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 301 301
Lines 38850 38854 +4
Branches 8185 8186 +1
=======================================
+ Hits 34333 34337 +4
Misses 3343 3343
Partials 1174 1174 ☔ View full report in Codecov by Sentry. |
dhirving
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In w.2023.50 the test passed because the config was sent as a Config object, but would fail if a path to a Config was used instead. Rewrite the test to use a file (which works now due to a later reorganization).
Checklist
doc/changes