DM-42580: Do not attempt to convert the label to a ResourcePath in butler config #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 303 303
Lines 38979 38979
Branches 8221 8221
=======================================
Hits 34448 34448
Misses 3339 3339
Partials 1192 1192 ☔ View full report in Codecov by Sentry. |
ktlim
approved these changes
Jan 21, 2024
With the recent change in ResourcePath to force /repo/main to an absolute URI the code that was seeing if anything was found got confused a bit because file:///repo/main was not the same as /repo/main. Change it to allow the get_repo_uri call to raise and if it raises continue to use the original label.
timj
force-pushed
the
tickets/DM-42580
branch
from
e508239
to
b7211c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent change in ResourcePath to force /repo/main to an absolute URI the code that was seeing if anything was found got confused a bit because file:///repo/main was not the same as /repo/main. Change it to allow the get_repo_uri call to raise and if it raises continue to use the original label.
Checklist
doc/changes