DM-15914: Use obs_metadata for unit extraction #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 8, 2018
python/lsst/daf/butler/instrument.py
Outdated
| @@ -64,74 +62,72 @@ def _addCamera(self, registry): | |||
| registry.addDataUnitEntry("Camera", {"camera": self.camera}) | |||
|
|
|||
| def _addPhysicalFilters(self, registry): | |||
| print("REGISTERING PHYSICAL FILTER") | |||
There was a problem hiding this comment.
I'm guessing you didn't intend to leave these in (more below).
There was a problem hiding this comment.
There are plenty of prints scattered about. I'll remove them before merging.
There was a problem hiding this comment.
They are mostly there so I could work out what logic was being triggered when.
timj
force-pushed
the
tickets/DM-15914
branch
3 times, most recently
from
707aeab
to
47efeb1
Compare
timj
force-pushed
the
tickets/DM-15914
branch
from
c405a68
to
8fc40ab
Compare
timj
force-pushed
the
tickets/DM-15914
branch
from
4b8a898
to
b7c2759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.