DM-41880: Support ChainedDatastore for Butler server #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement prepare_get_for_external_client in ChainedDatastore so that Butler server will work with ChainedDatastore. The Butler deployment on idfprod uses ChainedDatastore.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
=======================================
Coverage 88.40% 88.41%
=======================================
Files 303 303
Lines 39145 39163 +18
Branches 8252 8256 +4
=======================================
+ Hits 34606 34625 +19
Misses 3332 3332
+ Partials 1207 1206 -1 ☔ View full report in Codecov by Sentry. |
When the DatasetRef contains datastore records, we now use them as the definitive source of truth for FileDatastore.knows(). This allows the function to avoid database I/O when datastore records are attached. The type of DatasetDatastoreRecords was made more exact -- code is assuming the truthy/falsy behavior of the Iterable as if it is was a list, and in practice it is always a list.
dhirving
force-pushed
the
tickets/DM-41880
branch
from
1d00a0c
to
3dcba9a
Compare
For Butler server, DatasetRef passed to datastore will always have datastore records attached. Avoid duplicate database queries for ChainedDatastore by using these records to select which datastore to use.
dhirving
force-pushed
the
tickets/DM-41880
branch
from
3dcba9a
to
26cdb0a
Compare
Co-authored-by: Tim Jenness <tjenness@lsst.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes