Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42812: Fix pydantic dimension record serialization with booleans #958

Merged
merged 4 commits into from Feb 12, 2024
Merged

DM-42812: Fix pydantic dimension record serialization with booleans #958

merged 4 commits into from Feb 12, 2024

Conversation

timj
Copy link
Member

@timj timj commented Feb 12, 2024 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj
Refresh pre-commit
5213d79
@timj
Move StrictBool to front of list
0870258 
Otherwise a bool will never be serialized as a bool since Int and Float
will take priority.
@timj
Add a test for exposure dimension record round trip
baf5be6 
Booleans were not working properly before but there was
no test for those.
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fee28c) 88.39% compared to head (7af0e39) 88.39%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files         307      307           
  Lines       39508    39508           
  Branches     8316     8316           
=======================================
  Hits        34922    34922           
  Misses       3373     3373           
  Partials     1213     1213

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

erykoff
erykoff approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a changelog entry as well.

@timj timj merged commit 0ac7c98 into main Feb 12, 2024
18 checks passed
@timj timj deleted the tickets/DM-42812 branch February 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @erykoff