Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42995: Add RemoteButlerRegistry #965

Merged
merged 1 commit into from Feb 26, 2024
Merged

DM-42995: Add RemoteButlerRegistry #965

merged 1 commit into from Feb 26, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Feb 22, 2024

Added a partial implementation of the registry property to RemoteButler. We now run the existing Registry test suite against RemoteButler's registry shim, by delegating unsupported methods to SqlRegistry via a new class HybridButlerRegistry.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 95.49550% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 88.53%. Comparing base (75d9858) to head (95e3a90).

Files Patch % Lines
...on/lsst/daf/butler/tests/hybrid_butler_registry.py 95.23% 5 Missing ⚠️
python/lsst/daf/butler/remote_butler/_registry.py 95.83% 3 Missing ⚠️
tests/test_remote_butler.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
+ Coverage   88.49%   88.53%   +0.03%     
==========================================
  Files         310      312       +2     
  Lines       39783    39998     +215     
  Branches     8348     8363      +15     
==========================================
+ Hits        35206    35412     +206     
- Misses       3366     3376      +10     
+ Partials     1211     1210       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving force-pushed the tickets/DM-42995 branch 2 times, most recently from 31dad45 to 4a3c722 Compare February 22, 2024 22:16
Added a partial implementation of the registry property to RemoteButler.  We now run the existing Registry test suite against RemoteButler's registry shim, by delegating unsupported methods to SqlRegistry via a new class HybridButlerRegistry.
@dhirving dhirving marked this pull request as ready for review February 22, 2024 22:30
@dhirving dhirving merged commit 87c5805 into main Feb 26, 2024
18 checks passed
@dhirving dhirving deleted the tickets/DM-42995 branch February 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants