DM-43027: Make RemoteButler.find_dataset consistent with DirectButler #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemoteButler now passes globs to the server if one is given as a collections parameter, instead of silently discarding them. It can also now handle "..." to mean "all collections". Explicit exceptions are now raised for regular expressions, which will not be supported in the future.
Fix an issue where RemoteButler would throw validation errors instead of allowing 'None' to be returned from find_dataset.
|
I originally got the ticket number wrong, so this PR was reviewed as "DM-42037" here: #967 |
timj
approved these changes
Feb 27, 2024
Handle propagation of storage classes from the input DatasetType to the output DatasetRef in RemoteButler.find_dataset, to match DirectButler behavior.
Add support for the timespan parameter to RemoteButler.find_dataset.
Add a method in RemoteButler's registry shim for findDatasets, and run registry tests against it.
dhirving
force-pushed
the
tickets/DM-43027
branch
from
9982304
to
b7a0883
Compare
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 312 313 +1
Lines 39998 40036 +38
Branches 8363 8371 +8
==========================================
+ Hits 35411 35444 +33
- Misses 3376 3379 +3
- Partials 1211 1213 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes