DM-43117: Allow exposure.day_obs in a WHERE clause #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we completely disallowed this if the modifier was an implied dimension, but now that day_obs has suddenly become an implied dimension there are many existing places that would need to be fixed if we do not allow it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 313 313
Lines 40182 40184 +2
Branches 8407 8407
=======================================
+ Hits 35570 35574 +4
+ Misses 3392 3390 -2
Partials 1220 1220 ☔ View full report in Codecov by Sentry. |
TallJimbo
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we completely disallowed this if the modifier was an implied dimension, but now that day_obs has suddenly become an implied dimension there are many existing places that would need to be fixed if we do not allow it.
Checklist
doc/changes