DM-43146: query system updates from the DM-42740 review #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops DatasetQueryResults and ChainedDatasetResults, and renames SingleTypeDatasetResults to DatasetRefQueryResults (we probably should have always had "Ref" in there for consistency with other query result types). This lets us consolidate HomogeneousQueryBase and CountableQueryBase into QueryBase and drop QueryDriver.resolve_collection_path.
Joining an unregistered dataset type is now just always an error, and so is overriding the storage class in join_dataset_search. This simplifies some state and logic.
We now put parentheses around anything that isn't a literal or a column reference whenever it appears in an expression, and hence we don't need the 'precedence' property anymore.
Turns out DM-42740 actually got the value wrong (I was looking at the length of run.host, not collection.name).
TallJimbo
force-pushed
the
tickets/DM-43146
branch
from
87b412d
to
df5c1b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
- Coverage 88.88% 88.88% -0.01%
==========================================
Files 329 329
Lines 42374 42241 -133
Branches 8741 8688 -53
==========================================
- Hits 37663 37544 -119
+ Misses 3457 3444 -13
+ Partials 1254 1253 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
added a release note for user-visible changes to(not user visible)doc/changes