Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43105: Add exposure.can_see_sky metadata field #972

Closed
wants to merge 1 commit into from

Conversation

timj
Copy link
Member

@timj timj commented Mar 4, 2024

Defaults to None when importing old YAML files. The importer can't really work out what the flag should be on import in that situation.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (c40c3fe) to head (23047d9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         329      329           
  Lines       42374    42374           
  Branches     8741     8741           
=======================================
  Hits        37663    37663           
  Misses       3457     3457           
  Partials     1254     1254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj
Copy link
Member Author

timj commented Mar 19, 2024

This PR is using the wrong ticket number. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant