DM-42079: Enable caching in one storage class for S3 tests #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggers the cache even though the formatter supports fromBytes and the serialized size if below the byte limit, because in one of the tests the file size is not stored and is -1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
==========================================
+ Coverage 88.90% 88.91% +0.01%
==========================================
Files 329 329
Lines 42330 42330
Branches 8703 8703
==========================================
+ Hits 37634 37639 +5
+ Misses 3444 3441 -3
+ Partials 1252 1250 -2 ☔ View full report in Codecov by Sentry. |
dhirving
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers the cache even though the formatter supports fromBytes and the serialized size if below the byte limit, because in one of the tests the file size is not stored and is -1.
Checklist
doc/changes