Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43570: Fix round-tripping of masked floating point columns introduced in DM-43187 #985

Merged
merged 3 commits into from Mar 29, 2024

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Mar 28, 2024

Checklist

  • [x ] ran Jenkins
  • [x ] added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (b1cf303) to head (95201bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         329      329           
  Lines       42473    42476    +3     
  Branches     8718     8717    -1     
=======================================
+ Hits        37778    37781    +3     
  Misses       3443     3443           
  Partials     1252     1252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These tests now make sure that astropy tables with or without
masks and with or without nans properly round-trip.
@erykoff erykoff merged commit 3d728c0 into main Mar 29, 2024
18 checks passed
@erykoff erykoff deleted the tickets/DM-43570 branch March 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants