Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43101: Fix type annotation of _serializedType property #986

Merged
merged 1 commit into from Mar 28, 2024

Conversation

timj
Copy link
Member

@timj timj commented Mar 28, 2024

Without this the SupportsSimple protocol wouldn't match things like DatasetRef.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Without this the SupportsSimple protocol wouldn't match
things like DatasetRef.
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (9f02822) to head (36c40a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   88.92%   88.92%   -0.01%     
==========================================
  Files         329      329              
  Lines       42351    42351              
  Branches     8704     8704              
==========================================
- Hits        37661    37660       -1     
  Misses       3441     3441              
- Partials     1249     1250       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit b51dcee into main Mar 28, 2024
17 of 18 checks passed
@timj timj deleted the tickets/DM-43101-hotfix branch March 28, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants