-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-43671: Implement atomic collection prepend #989
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
05ef027
Add type annotation for CollectionTablesTuple
dhirving 4ae0688
Add isInTransaction() to DB
dhirving ffefc71
Factor out collection chain insert function
dhirving def8d69
Implement chained collection prepend
dhirving 601d5bc
Handle cache invalidation for chain prepend
dhirving dc1ed9f
Factor out collection cycle check function
dhirving c7ca697
Check for collection cycles in chain prepend
dhirving 910f816
Add test for concurrent collection chain prepend
dhirving e73b1cf
Make CollectionTypeError a top-level exception
dhirving 59b42c6
Make setCollectionChain more concurrency-safe
dhirving ea71ce1
Use atomic prepend in the collection chain CLI
dhirving 6339f2d
Add towncrier
dhirving 11941a9
Use futures for chain concurrency test
dhirving 023e418
Prevent prepend from creating duplicates
dhirving 9dea0ac
Simplify position calculation
dhirving ce81f8e
Forbid prepend_collection_chain in caching context
dhirving File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
enumerate
inside the list comprehension plus an offset seems a little less error-prone. I don't know why that wasn't the case before.