DM-43746: Clean up RemoteButler #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirving
force-pushed
the
tickets/DM-43746
branch
from
e444325
to
1f6921f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 339 341 +2
Lines 44016 44036 +20
Branches 9071 9072 +1
=======================================
+ Hits 39151 39169 +18
- Misses 3551 3552 +1
- Partials 1314 1315 +1 ☔ View full report in Codecov by Sentry. |
RemoteButler is getting too large, so pull out some HTTP-related methods that can be grouped together in their own class.
dhirving
force-pushed
the
tickets/DM-43746
branch
from
1f6921f
to
6d49762
Compare
timj
reviewed
Apr 8, 2024
timj
approved these changes
Apr 8, 2024
| content: bytes | None = None, | ||
| params: Mapping[str, str | bool] | None = None, | ||
| headers: Mapping[str, str] | None = None, | ||
| ) -> httpx.Response: |
There was a problem hiding this comment.
In some sense, this is the most complicated method in the file and the one that might want a couple of sentences to explain it.
dhirving
force-pushed
the
tickets/DM-43746
branch
from
6d49762
to
5c3bc97
Compare
Pull out some standalone functions from RemoteButler to a new file to cut down clutter.
dhirving
force-pushed
the
tickets/DM-43746
branch
from
5c3bc97
to
c8364de
Compare
Co-authored-by: Tim Jenness <tjenness@lsst.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteButler is getting too large, cut down clutter in the main file by factoring out a
RemoteButlerHttpConnectionclass and moving some standalone functions to their own file.Checklist
doc/changesconfigs/old_dimensions