DM-43925: Add workarounds for pandas bugs when using non-floating-point masked columns. #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 344 344
Lines 44199 44226 +27
Branches 9100 9106 +6
==========================================
+ Hits 39327 39351 +24
- Misses 3556 3557 +1
- Partials 1316 1318 +2 ☔ View full report in Codecov by Sentry. |
erykoff
force-pushed
the
tickets/DM-43925
branch
from
b6e3cf6
to
d847c64
Compare
taranu
approved these changes
Apr 18, 2024
| """ | ||
| dataframe = arrow_to_pandas(astropy_to_arrow(astropy_table)) | ||
|
|
||
| if isinstance(index, str): |
There was a problem hiding this comment.
Should this raise if it's not a string or None? If not, what about just if index:?
| @@ -584,6 +588,23 @@ def testWriteMultiIndexDataFrameReadAsAstropyTable(self): | |||
| # This test simply checks that it's readable, but definitely not | |||
| # recommended. | |||
|
|
|||
| @unittest.skipUnless(atable is not None, "Cannot test writing as astropy without astropy.") | |||
| def testWriteAstropyTableWithMaskedColsReadAsSingleIndexDataFrame(self): | |||
There was a problem hiding this comment.
That is quite the mouthful... though I don't have a better suggestion.
erykoff
force-pushed
the
tickets/DM-43925
branch
from
d847c64
to
e620aae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions