DN-37738: investigate downstream CI failure due to typing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-37738
branch
3 times, most recently
from
f64af0c
to
d9333a5
Compare
TallJimbo
force-pushed
the
tickets/DM-37738
branch
from
d9333a5
to
db31d2a
Compare
SQLAlchemy now defines ColumnElement as generic, and we don't really want to make use of that since we usually hold columns in heterogeneous containers (I imagine this typing is much more useful for the ORM). In most contexts, not providing a type variable is interpreted as ColumnElement[Any], but it seems to be causing trouble here in inheritance involving Generic, as it makes Python want the Generic to include the typevar for ColumnElement.
Codecov ReportBase: 97.11% // Head: 97.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 15 15
Lines 1246 1246
Branches 117 117
=======================================
Hits 1210 1210
Misses 19 19
Partials 17 17 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TallJimbo
force-pushed
the
tickets/DM-37738
branch
from
55e9d27
to
71f663a
Compare
natelust
approved these changes
Jan 27, 2023
| @@ -532,6 +534,7 @@ def _select_to_executable( | |||
| `to_payload` for all other relation types. | |||
| """ | |||
| columns_available: Mapping[ColumnTag, _L] | None = None | |||
| executable: sqlalchemy.sql.Select | sqlalchemy.sql.CompoundSelect | |||
There was a problem hiding this comment.
Are we only supporting python 3.10 now?
There was a problem hiding this comment.
Yes, daf_relation has been 3.10-only from its inception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[ ] ran Jenkinsskipped because this only touches type annotationsdoc/changes