Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-30985: Change schema file discovery to use environment variables and expandvars #19

Merged
merged 1 commit into from Jul 3, 2021

Conversation

timj
Copy link
Member

@timj timj commented Jul 2, 2021

This changes the config items to support environment variables rather
than using getPackageDir. This allows runtime evaluation of the
file path rather than config read evaluation (which then gets
written to quantum graph files). This allows graph building to
run on a different system to the system that executes that graph.

This is required for lsst/ap_association#119

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but the PR title should say DM-30985.

Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one style comment.

python/lsst/dax/apdb/apdbSchema.py Outdated Show resolved Hide resolved
@timj timj changed the title DM-30975: Change schema file discovery to use environment variables and expandvars DM-30985: Change schema file discovery to use environment variables and expandvars Jul 2, 2021
This changes the config items to support environment variables rather
than using getPackageDir. This allows runtime evaluation of the
file path rather than config read evaluation (which then gets
written to quantum graph files). This allows graph building to
run on a different system to the system that executes that graph.
@timj timj merged commit a324b9c into master Jul 3, 2021
@timj timj deleted the tickets/DM-30985 branch July 3, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants