DM-31619: Fully incorporate SSP object association in DiaPipe #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
reviewed
Oct 8, 2021
python/lsst/dax/apdb/apdbSql.py
Outdated
Comment on lines
781
to
784
| if diaObjId == 0: | ||
| continue | ||
| else: | ||
| htm_index[i] = pixel_id_map[diaObjId] |
There was a problem hiding this comment.
Looks good, maybe a slightly faster way to do it is to set pixel_id_map[0] = 0, then you don't need to check every diaObjId for 0.
There was a problem hiding this comment.
Sorry, how do I know if it's a DiaSource I shouldn't touch?
There was a problem hiding this comment.
ah, got ya now. I'll put the change in.
Modify test to start with 1 indexed ids for DiaObjects. Add DiaObject id=0 to pixel map.
morriscb
force-pushed
the
tickets/DM-31619
branch
from
7420888
to
ef86eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add htm skip for SolarSystem associated DiaSources
Modify test to start with 1 indexed ids for DiaObjects.