DM-33314: Implement missing methods for Cassandra backend #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packing columns into blobs did not help with performance, and storage size grows too. Not useful, getting rid of it to simplify things.
n8pease
reviewed
Mar 14, 2022
| # prepare it because it's not reusable. | ||
| statement = cassandra.query.SimpleStatement(full_query) | ||
| statements.append((statement, params)) | ||
| _LOG.debug("getDiaObjects: #queries: %s", len(statements)) | ||
| # _LOG.debug("getDiaObjects: queries: %s", queries) |
n8pease
reviewed
Mar 14, 2022
| values = (ssObjectId, apdb_part, apdb_time_part, diaSourceId) | ||
| queries.add(self._prep_statement(query), values) | ||
|
|
||
| # _LOG.debug("query: %s", query) |
n8pease
reviewed
Mar 15, 2022
| if not clust_columns: | ||
| raise ValueError(f"Table {table_name} configuration is missing primary index") | ||
| # if not clust_columns: | ||
| # raise ValueError(f"Table {table_name} configuration is missing primary index") |
There was a problem hiding this comment.
I forgot to clean that up after testing, will remove it completely.
|
LGTM! |
The implementation uses ssObjectId for partitioning key, there are no other natural keys and size is too large for one partition. This may be reconsidered once we learn more about how SSObjects will be queried.
Efficient search by diaSourceId needs another table which is partitioned by that column. There may be other ways to implement association, will need to think more about it.
Remove non_prepared_statements option, always use prepared.
andy-slac
force-pushed
the
tickets/DM-33314
branch
from
7cde542
to
7a03f92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APDB API added few methods to support replication to/from PPDB on a previous ticket. This update adds an implementation of these new methods to Cassandra backend. Cassandra code was updated to use execution profiles, as the previous model gets deprecated. Also a continuing refactoring of Cassandra implementation in a couple of commits. It makes sense to look at the final diff, some pieces were changed more than once.