Disable sqlalchemy 2 workaround for pandas 2 (DM-38553) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-38553
branch
from
f394890
to
6d6b5a7
Compare
Pandas 2.0 has a better support for sqlalchemy 2. The workaround that was needed for pandas 1 is no longer necessary and is conditionally disabled. When we migrate to pandas2 completely, that workaround can be removed.
andy-slac
force-pushed
the
tickets/DM-38553
branch
from
6d6b5a7
to
c4051f5
Compare
ktlim
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 2.0 has a better support for sqlalchemy 2. The workaround that was needed for pandas 1 is no longer necessary and is conditionally disabled. When we migrate to pandas2 completely, that workaround can be removed.
This commit also fixes few mypy issues that appeared with new mypy version.