DM-40819: Few improvements to dax_apdb code #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsertId class adds insert_time field to allow filtering based on time window. Cassandra deleteInsertIds method now removes data from all tables.
Special PRAGMA needed for sqlite to enable foreign keys support, without it cascade delete did not work for insert_id tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ticket was for finding the best compaction options for Cassandra implementation, but that work has been postponed. The branch has a bunch of small improvements to the code - mypy, enabling foreign keys in sqlite. I'm going to merge this branch to avoid future conflicts with other development.