DM-41639: Allow Apdb queries for visit completion #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-41639
branch
2 times, most recently
from
bf2faf1
to
3c1342a
Compare
andy-slac
approved these changes
Nov 8, 2023
This method allows tests of whether a particular visit-detector has already been stored in the APDB.
This method does the same thing as Apdb.containsVisitDetector, but takes as input a "packed" visit-detector ID instead of separate visit and detector IDs. This alternative is necessary because, at present, the packed ID is the only form of the information in the database, and the packing process requires information that dax.apdb.Apdb should not have access to. containsCcdVisit can be replaced with contains once either a dedicated table is created, or Dia*Source use visit and detector internally.
kfindeisen
force-pushed
the
tickets/DM-41639
branch
from
3c1342a
to
1006513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two methods for querying the presence of a visit-detector on an APDB. The first,
Apdb.contains, is the preferred long-term solution, but cannot be implemented without schema changes. The second,ApdbSql.containsCcdVisit, can work right away but requires arguments that are not compatible withcontains(and cannot be efficiently implemented in Cassandra).The Jira issue(s) that would allow
containsCcdVisitto be retired in favor ofcontainsshould be defined before this PR is merged.