DM-42489: Freeze APDB configuration in metadata table #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `makeSchema` as an instance method causes too many issues, as the state of the instance has to be reset after schema is created or re-created. Now Apdb instances will be created only on populated database schema. Base class method can be used to call `makeSchema` and it will dispatch to a correct sub-class based on confguration object type. This change means that in-memory SQLite database cannot be used with ApdbSql, in-memory database was only useful for testing.
andy-slac
force-pushed
the
tickets/DM-42489
branch
from
e2568d8
to
412daa3
Compare
Both implementations now store parts of configuration in metadata table (if that table exists in the schema) and reload that configuration when instantiated.
andy-slac
force-pushed
the
tickets/DM-42489
branch
from
412daa3
to
d77e54a
Compare
ebellm
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both implementations now store parts of configuration in metadata
table (if that table exists in the schema) and reload that configuration
when instantiated.