DM-42798: Add a test for missing metadata table #43
Conversation
| # database is missing it. | ||
| apdb = make_apdb(config) | ||
| metadata = apdb.metadata | ||
| self.assertTrue(metadata.empty()) |
There was a problem hiding this comment.
Sorry, I don't understand this test. How does it create a scenario where the DB is missing the metadata table? I assume that, with the above rename, config is still the baseline config...
There was a problem hiding this comment.
config here is indeed a baseline config which has metadata table, but the database schema is created above with config_nometa which is missing metadata table (it is dropped from configuration by update_schema_yaml()).
There was a problem hiding this comment.
Ah, got it. Then please add a comment noting that the APDB was initialized previously. It's a bit too easy to miss that the steps aren't independent.
| # database is missing it. | ||
| apdb = make_apdb(config) | ||
| metadata = apdb.metadata | ||
| self.assertTrue(metadata.empty()) |
There was a problem hiding this comment.
Ah, got it. Then please add a comment noting that the APDB was initialized previously. It's a bit too easy to miss that the steps aren't independent.
The issue on this ticket has been fixed already (accidentally) on DM-42489, but there was no unit test for this problem. Extended one of the unit tests to cover it.
andy-slac
force-pushed
the
tickets/DM-42798
branch
from
6a028cb
to
3abc944
Compare
The issue on this ticket has been fixed already (accidentally) on DM-42489, but there was no unit test for this problem. Extended one of the unit tests to cover it.