DM-43509: Replace daf.base.DateTime with astropy Time #47
Conversation
This removes dependency on daf_base which should allow adding GA for building and testing this package.
I forgot about Cassndra when reviewed DM-43270 (and Cassandra tests are only run manually). Adding the same check as for SQL backend.
andy-slac
force-pushed
the
tickets/DM-43509
branch
from
3df779f
to
affb4ac
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
andy-slac
force-pushed
the
tickets/DM-43509
branch
from
affb4ac
to
8f2c9ce
Compare
There was a problem hiding this comment.
I'm a bit concerned by the codecov lines saying the cassandra code isn't covered by tests. Could we lift much of the time handling (and maybe some other generic code) from the Cassandra and Sql implementations of Apdb and put them in some methods on the base class to improve test-ability?
Otherwise, this looks fine.
|
Cassandra tests do not run in GA (they need Cassandra instance and I could not find an easy way yet to spin up something in github). I do run tests manually against the Cassandra cluster when I develop at my private server, so all regular tests are executed from time to time. The code wants some refactoring, I hope I can spend some time on that after DM-43414, that would be a good opportunity to make more things shared between implementations. |
This removes dependency on daf_base which should allow adding GA
for building and testing this package.