Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43933: Add special service for collecting monitoring metrics #51

Merged
merged 3 commits into from Apr 26, 2024

Conversation

andy-slac
Copy link
Collaborator

New service can collect monitoring records (which is a collection of
tags and values) and publish them somewhere. For now publishing
to log stream is supported with records formatted as JSON objects.
Timer class is updated to publish timing info to monitoring service
in addition to logs.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 85.89744% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 70.75%. Comparing base (d2a12a3) to head (47a6cad).
Report is 11 commits behind head on main.

❗ Current head 47a6cad differs from pull request most recent head 09fbdc7. Consider uploading reports for the commit 09fbdc7 to get more accurate results

Files Patch % Lines
python/lsst/dax/apdb/cassandra/apdbCassandra.py 25.00% 12 Missing ⚠️
python/lsst/dax/apdb/monitor.py 88.46% 9 Missing and 3 partials ⚠️
python/lsst/dax/apdb/timer.py 72.41% 6 Missing and 2 partials ⚠️
...on/lsst/dax/apdb/cassandra/apdbCassandraReplica.py 30.00% 7 Missing ⚠️
python/lsst/dax/apdb/sql/apdbSql.py 88.88% 1 Missing and 1 partial ⚠️
python/lsst/dax/apdb/sql/apdbSqlReplica.py 77.77% 1 Missing and 1 partial ⚠️
python/lsst/dax/apdb/scripts/create_cassandra.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   67.23%   70.75%   +3.51%     
==========================================
  Files          33       44      +11     
  Lines        3211     3843     +632     
  Branches      585      685     +100     
==========================================
+ Hits         2159     2719     +560     
- Misses        977     1036      +59     
- Partials       75       88      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

New service can collect monitoring records (which is a collection of
tags and values) and publish them somewhere. For now publishing
to log stream is supported with records formatted as JSON objects.
Timer class is updated to publish timing info to monitoring service
in addition to logs.
@andy-slac andy-slac merged commit 5ea96fc into main Apr 26, 2024
8 checks passed
@andy-slac andy-slac deleted the tickets/DM-43933 branch April 26, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant