DM-43369: Use shutil.which instead of distutils #24
+27
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils is no longer part of python 3.12. shutil.which has been available since python 3.3.
timj
commented
Mar 18, 2024
| @@ -365,10 +365,10 @@ def _setMaskTransparency(self, transparency, maskplane): | |||
| ignored. | |||
| """ | |||
| if maskplane is not None: | |||
| print("ds9 is unable to set transparency for individual maskplanes" % maskplane, | |||
| print(f"ds9 is unable to set transparency for individual maskplanes ({maskplane})", | |||
There was a problem hiding this comment.
This line was using % but didn't have anywhere to place the variable, so I added the variable to the end. I imagine this line doesn't get triggered very often.
ktlim
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils is no longer part of python 3.12. shutil.which has been available since python 3.3.