Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swig fixes to handle unicode in py2 #3

Merged
merged 1 commit into from Oct 18, 2016
Merged

swig fixes to handle unicode in py2 #3

merged 1 commit into from Oct 18, 2016

Conversation

stargaser
Copy link
Contributor

  • removed the .encode() from ds9.py
  • added the SWIG_PYTHON_2_UNICODE directive to xpa.i
  • added missing python_future from ups/display_ds9.table

Tested with afw/tests/testDisplay.py in py2 and py3 build trees

@stargaser
Copy link
Contributor Author

@timj would you mind doing a quick review please? I have tested in py2 and py3 build trees already

timj
timj approved these changes Oct 18, 2016
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@stargaser stargaser merged commit e1d788f into master Oct 18, 2016
@ktlim ktlim deleted the tickets/DM-7895-swig-fixes branch August 25, 2018 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees

@timj timj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stargaser @timj