DM-14391 Simplify initialization of display_firefly and firefly_client #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
May 17, 2018
| @@ -0,0 +1,273 @@ | |||
| .. _display_firefly: | |||
There was a problem hiding this comment.
I think doing a git mv would have let you preserve the diff.
| _fireflyClient = firefly_client.FireflyClient(channel=name, **kwargs) | ||
| else: | ||
| _fireflyClient = firefly_client.FireflyClient(url, | ||
| channel=name, **kwargs) |
There was a problem hiding this comment.
According to our standards, I think channel should be aligned with url.
| _fireflyClient = firefly_client.FireflyClient(channel=name, **kwargs) | ||
| else: | ||
| _fireflyClient = firefly_client.FireflyClient(url, | ||
| channel=name, **kwargs) | ||
| except Exception as e: |
There was a problem hiding this comment.
Typically it's better to trap the exceptions you expect. Trapping a bare exception means you can't tell what actually went wrong when something unexpected happens.
There was a problem hiding this comment.
Agreed. I'll trap on the two exceptions that are raised, one for a nonsense url and one for a working web server that is not a Firefly url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the
display_fireflybackend to enable easier initialization. These changes go together with the 2.0.0+ version offirefly_client.nameto None, to allowfirefly_clientto auto-initialize the channel.hosttourlto track the new initialization offirefly_client.FireflyClient.urlunspecified, to allowFireflyClientto initialize from environment variables, as will be provided in LSST Science Platform environments.FireflyClientinstance and the browser url as attributes.