DM-14732 Regions appear on subsequent afw Displays with Firefly backend #12
Conversation
| @@ -140,7 +147,8 @@ def _mtv(self, image, mask=None, wcs=None, title=""): | |||
| self._fireflyFitsID = _fireflyClient.upload_data(fd, 'FITS') | |||
|
|
|||
| ret = _fireflyClient.show_fits(self._fireflyFitsID, plot_id=str(self.display.frame), | |||
| Title=title, MultiImageIdx=0) | |||
| Title=title, MultiImageIdx=0, | |||
| PredefinedOverlayIds=' ') | |||
There was a problem hiding this comment.
If this is really supposed to be a single space, rather than an empty string or some other more typical custom value, it probably merits a code comment explaining why.
There was a problem hiding this comment.
It does have to be a space, or else the Javascript side discards the parameter...I'll add a comment
| """ | ||
| self._client.dispatch_remote_action(channel=self._client.channel, | ||
| action_type='ImagePlotCntlr.deletePlotView', | ||
| payload=dict(plotId=str(self.display.frame))) |
There was a problem hiding this comment.
I understand that you trying calling this in _mtv and it didn't help with this particular problem, but if it does no harm it may be exactly what's needed to fix DM-14695, in that it seems to be a programmatic way to do exactly what I was doing in the GUI in my workaround (though I gather there may be different fix for that issue already in the works).
There was a problem hiding this comment.
It does fix the mask but it deletes the image entirely. @robyww and I looked at this and decided this was undesirable. Once you have, say, three displays up, and you mtv again to the first one, displays 2 and 3 shift to the left and display 1 appears on the right. Trey has a server-side fix that we will do instead.
| @@ -125,6 +125,13 @@ def __init__(self, display, verbose=False, url=None, | |||
| def _getRegionLayerId(self): | |||
| return "lsstRegions%s" % self.display.frame if self.display else "None" | |||
|
|
|||
| def _clear_image(self): | |||
There was a problem hiding this comment.
I think this should probably be _clearImage, since this class inherits from a base class that definitely uses the camelCase conventions used in Science Pipelines code, but it's a bit of a grey area and I won't insist (especially since it's a private method).
* add comment explaining space in parameter string * change method to _clearImage
stargaser
force-pushed
the
tickets/DM-14732
branch
from
2e1d648
to
cc3a82e
Compare
_clearImagemethod to the Firefly backendshow_fits, clear the list of predefined overlays that are carried over to new image displaysThe
_clearImagemethod did not fix the issue of having regions overlays appear on new displays, but it is retained as a potentially useful method in the backend.