Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14734 Allow zoom to be set before mtv in afw Displays for Firefly backend #13

Merged
merged 1 commit into from Jun 8, 2018

Conversation

stargaser
Copy link
Contributor

To improve display performance in certain situations, allow a zoom before an mtv.

  • Save the last commanded zoom level
  • Apply the zoom level when uploading an image with mtv

By request of @gpdf also remember the pan coordinates. When we have a better API then we can use them.

also remember pan level as we'll use it when we have a better API ready
@stargaser stargaser requested a review from TallJimbo June 8, 2018 22:54

if self._lastZoom:
extraParams['InitZoomLevel'] = self._lastZoom
extraParams['ZoomType'] = 'LEVEL'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a similar block for panning here, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some concerns about that leaving an overlay at that position...however let me give it a try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the right API right now so it will be added once we have that on the Firefly end.

@stargaser stargaser merged commit cc98cfc into master Jun 8, 2018
@stargaser stargaser changed the title Allow zoom to be set before mtv in afw Displays for Firefly backend DM-14734 Allow zoom to be set before mtv in afw Displays for Firefly backend Jun 10, 2018
@ktlim ktlim deleted the tickets/DM-14734 branch August 25, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants