Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-14763 Improve region ID handling in display_firefly #14

Merged
merged 1 commit into from Jun 14, 2018
Merged

DM-14763 Improve region ID handling in display_firefly #14

merged 1 commit into from Jun 14, 2018

Conversation

stargaser
Copy link
Contributor

  • initialize _regionLayerId to the string we use for each display
  • don't set the regionLayerId to None after an erase
  • add some verbose prints

@stargaser stargaser requested a review from robyww June 14, 2018 17:49
robyww
robyww approved these changes Jun 14, 2018
View reviewed changes
Copy link

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fix makes sense.

@stargaser stargaser merged commit 72d55a8 into master Jun 14, 2018
@ktlim ktlim deleted the tickets/DM-14763 branch August 25, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww robyww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stargaser @robyww