Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters for asinh and power law_gamma to display_firefly #15

Merged
merged 1 commit into from Jul 27, 2018
Merged

Add parameters for asinh and power law_gamma to display_firefly #15

merged 1 commit into from Jul 27, 2018

Conversation

stargaser
Copy link
Contributor

Since afw.display.scale already passes **kwargs, translate these into what firefly_client uses:

  • translate Q into asinh_q_value
  • translate gamma into gamma_value
  • pass **kwargs properly to FireflyClient.set_stretch

@stargaser stargaser requested a review from robyww July 27, 2018 22:30
robyww
robyww approved these changes Jul 27, 2018
View reviewed changes
Copy link

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stargaser stargaser merged commit 284a423 into master Jul 27, 2018
@ktlim ktlim deleted the tickets/DM-15232 branch August 25, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww robyww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stargaser @robyww