DM-15333 Apply pan and scale at time of image display in display_firefly #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoldina
approved these changes
Aug 8, 2018
| # center of the first pixel. | ||
| extraParams['InitialCenterPosition'] = '{0:.3f};{1:.3f};PIXEL'.format( | ||
| self._lastPan[0]+0.5, | ||
| self._lastPan[1]+0.5) |
There was a problem hiding this comment.
We can save the corrected value in _lastPan rather than applying the correction in two places.
| if not specified, min and max are presumed to be in 'absolute' units. | ||
|
|
||
| *args, **kwargs : additional keyword arguments, e.g. Q for asinh | ||
| and gamma for powerlaw_gamma |
There was a problem hiding this comment.
Do we want to document all keys here or it's OK to skip zscale parameters, because people commonly use the default values? (Can we refer to Firefly's set_stretch docs for extra info?)
There was a problem hiding this comment.
Yes, it would be good to document zscale parameters here. We can also refer to set_stretch, perhaps with a link to online documentation.
stargaser
force-pushed
the
tickets/DM-15333
branch
from
6fd2b34
to
bf7ee46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
display_fireflybackend to remember the results of scale (stretch) commands, and to apply scale and pan parameters when displaying an image withlsst.afw.display.mtv.mtv'slate.html'the default if it is not passed explicitly or if the environment variableFIREFLY_HTMLis not defined. This is necessary for Firefly to show readout of LSST pixel convention.