DM-14840 Make mask transparency and color "sticky" in display_firefly #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stargaser
force-pushed
the
tickets/DM-14840
branch
from
ffd31a2
to
2218967
Compare
hsinfang
reviewed
Aug 10, 2018
| usedPlanes = long(afwMath.makeStatistics(mask, afwMath.SUM).getValue()) | ||
| for k in self._maskDict: | ||
| if ((1 << self._maskDict[k]) & usedPlanes): | ||
| if (((1 << self._maskDict[k]) & usedPlanes) and | ||
| (k in self._maskPlaneColors) and |
There was a problem hiding this comment.
Can this condition (k in self._maskPlaneColors) ever be false?
There was a problem hiding this comment.
Good question! Looking at an example, _maskPlaneColors has fewer keys than _maskDict (which seems to have all possibilities) so it's possible to reference a key not in _maskPlaneColors.
There was a problem hiding this comment.
Looking at line 192 and 193, I thought _maskDict and _maskPlaneColors would have identical keys. But I didn't read other part of the code so probably missed some subtleties.
hsinfang
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMaskTransparencymethod_mtvmethod