DM-16441 Speed up creation of footprints table for Firefly #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stargaser
commented
Nov 5, 2018
stargaser
commented
- Replace slow loop over table rows with column-wise copies
- Delete the intermediate Astropy table after we've made a VOTable from it
- Stream the footprints VOTable to Firefly using BytesIO
stargaser
force-pushed
the
tickets/DM-16441
branch
from
93e0b82
to
4ef8440
Compare
tgoldina
approved these changes
Nov 6, 2018
| elif (('base_NaiveCentroid_x' in inputColumnNames) and | ||
| ('base_NaiveCentroid_y' in inputColumnNames) and | ||
| np.isfinite(outTable.array['base_NaiveCentroid_x']).any() and | ||
| np.isfinite(outTable.array['base_NaiveCentroid_y']).any()): | ||
| coord_column_string = 'base_NaiveCentroid_x;base_NaiveCentroid_y;ZERO-BASED' | ||
| else: | ||
| raise RuntimeError('No valid coordinate columns in catalog') |
There was a problem hiding this comment.
It might be more efficient if we did all error checking and modifications on the original table and converted to the VO format at the end.
There was a problem hiding this comment.
Yes, this check could be made earlier until waiting to test for valid coordinates at the end. We are likely going to make more changes to the columns that are used for the center coordinates of the footprints so this should be kept in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.