New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16451 Fix color parameter names for overlaying footprints #21

Merged

stargaser merged 2 commits into master from tickets/DM-16451

Nov 6, 2018

Contributor

stargaser commented Nov 6, 2018

Use the correct parameter names highlightColor and selectColor in the call to firefly_client.FireflyClient.overlay_footprints
In the example notebook, change highlightColor to 'yellow'

stargaser added 2 commits

November 6, 2018 15:04


          correct parameters for highlight and select colors

d669f38


          change nb highlight color to yellow

86539bf

stargaser requested a review from cwang2016

November 6, 2018 23:20

cwang2016 approved these changes

View reviewed changes

cwang2016 commented Nov 6, 2018

good.

stargaser merged commit 86539bf into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment