Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16518 Write footprints table for Firefly viewer in binary2 format #22

Merged
merged 3 commits into from Nov 29, 2018
Merged

DM-16518 Write footprints table for Firefly viewer in binary2 format #22

merged 3 commits into from Nov 29, 2018

Conversation

stargaser
Copy link
Contributor

@stargaser stargaser commented Nov 27, 2018 •
edited

  • Write the footprints table in binary2 format, making as many modifications as possible to the table in the form of an astropy.table.Table format
  • Remove the code that changed the units of seconds, because the warning doesn't happen anymore. It appears to have been fixed in LSST Science Pipelines code.
  • If available, use slots_Centroid_x and slots_Centroid_y for the footprint centers

tgoldina
tgoldina approved these changes Nov 28, 2018
View reviewed changes
Copy link

@tgoldina tgoldina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Tested with HSC-Footprints.ipynb.

@stargaser stargaser merged commit 790031e into master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgoldina tgoldina tgoldina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stargaser @tgoldina