Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16782 Update display_firefly to working firefly_client changes #24

Merged
merged 8 commits into from Jan 24, 2019
Merged

DM-16782 Update display_firefly to working firefly_client changes #24

merged 8 commits into from Jan 24, 2019

Conversation

stargaser
Copy link
Contributor

  • Change backend initialization to use Jupyter Firefly extension if it is available
  • Update Javascript API calls to use the new dispatch method
  • Update the user guide using the legacy display_firefly reStructuredText file

@stargaser stargaser changed the title Update display_firefly to working firefly_client changes DM-16782 Update display_firefly to working firefly_client changes Dec 13, 2018
@cwang2016
Copy link

code review completes. Looks clear and good.

@stargaser stargaser merged commit 278b9b0 into master Jan 24, 2019
@stargaser stargaser deleted the tickets/DM-16782 branch February 7, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwang2016 cwang2016 cwang2016 approved these changes

@robyww robyww Awaiting requested review from robyww

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stargaser @cwang2016