Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18167 display_firefly needs to handle viewer_ids properly #28

Merged
merged 2 commits into from Mar 2, 2019
Merged

DM-18167 display_firefly needs to handle viewer_ids properly #28

merged 2 commits into from Mar 2, 2019

Conversation

stargaser
Copy link
Contributor

The lsst.display.firefly backend needs to make a unique viewer_id when displaying images. This bugfix is to add the render_tree_id to the viewer_id so that it is unique whenever a new Firefly tab is opened, when using jupyter_firefly_extensions.

@stargaser stargaser requested a review from robyww March 1, 2019 23:08
robyww
robyww approved these changes Mar 1, 2019
View reviewed changes
Copy link

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@stargaser stargaser merged commit a4f988a into master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww robyww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stargaser @robyww